[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

buffer overflow in admin/copy.c



Hi,

please find below a patch for admin/copy.c. I think it is necessary because of
 ...
    int i = 0;

    args[i++].value = &help_flag;
    args[i++].value = &verbose_flag;
...

but I do not know if I had the correct idea about the args struct. Here is the 
patch:

--- heimdal-0.5.1/admin/copy.c.orig     2003-01-16 15:26:03.000000000 +0100
+++ heimdal-0.5.1/admin/copy.c  2003-01-16 15:27:57.000000000 +0100
@@ -137,7 +137,8 @@
     int optind = 0;

     struct getargs args[] = {
-       { "help", 'h', arg_flag, NULL}
+       { "help", 'h', arg_flag, NULL},
+       { "verbose", 'v', arg_flag, NULL}
     };

     int num_args = sizeof(args) / sizeof(args[0]);


bye,
Sumit
-- 
Dr. Sumit Bose                                  E-Mail: Sumit.Bose@suse.de 
SuSE Linux AG -- Berlin                                http://www.suse.de/
Berliner Str. 27                               Tel: +49 (0)30-43 09 44-785
D-13507 Berlin                                  Fax: +49 (0)30-43 47 28 04