[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: none
> I think you are mixing compile time and runtime checks in a non obvious
> manner.
Compile time? Runtime? Configure is compile time isn't it? But I don't
care so much what it is called, it is run when configure is run and my
patch works. Your patch has a small typo and the bigger problem that
in most cases with_$1_config will be set to something *-config three
rows higher up and therefore
> case "$with_$1_config" in
> yes|no|"")
^^^^^^^^^^--nope
> + if test -f $with_$1/bin/$with_$1_config ; then
> + $with_$1_config=$with_$1/bin/$with_$1_config
^--nope
> + fi
> + ;;
> +easc
^^^^--nope
the with + marked statements never will be executed. Neither does
the $with_$1_config= work as expected ;-)
I'd say instead:
*** cf/test-package.m4.orig Tue Sep 10 17:23:38 2002
--- cf/test-package.m4 Mon Jan 26 23:21:34 2004
***************
*** 71,76 ****
--- 71,79 ----
yes|no|"")
;;
*)
+ if test -x $with_$1/bin/$with_$1_config ; then
+ with_$1_config=$with_$1/bin/$with_$1_config
+ fi
$1_cflags="`$with_$1_config --cflags 2>&1`"
$1_libs="`$with_$1_config --libs 2>&1`"
;;
Harald.