Re: heimdal 0.6.4 KDC v4 support broken?

[Academician Kula <kula@tproa.net>]

On Fri, May 27, 2005 at 07:46:04PM -0500, Academician Kula wrote:

> --- kdc/kerberos4.c.orig        2005-05-17 19:07:12.000000000 -0500
> +++ kdc/kerberos4.c     2005-05-17 19:08:22.000000000 -0500
> @@ -387,7 +387,7 @@
>                   "%s.%s@%s",
>                   ad.pname, ad.pinst, ad.prealm);
>         ret = db_fetch4(ad.pname, ad.pinst, ad.prealm, &client);
> -       if(ret != HDB_ERR_NOENTRY || 
> +       if(ret == HDB_ERR_NOENTRY || 
>            (ret == HDB_ERR_NOENTRY && strcmp(ad.prealm, v4_realm) == 0)) {
>             char *s;
>             s = kdc_log_msg(0, "Client not found in database: (krb4) "
> 
> seemed to make sense to me (and it started working). This is my first
> time trolling through heimdal, so the second bit doesn't make much sense
> to me and I left it alone. I haven't looked at 0.7rc1 to see if it
> works or not.

As Brandon Allbery pointed out to me, this means that you lose any 
other number of return values db_fetch4 can return, so it shouldn't
be used. 

-- 
Thomas L. Kula | kula@tproa.net | http://www.madscientistresearch.net
Mathom House upon the Canw, The People's Republic of Ames